Fix a crash in Logger::LogCompiledFunctions due to a presence of scripts with disposed source.

Fix a crash in Logger::LogCompiledFunctions due to a presence of scripts with disposed source.

When starting JS profiling under Chromium, a map from function addresses to function names is created. During it, for sourceful scripts, an attempt to access script source is made. This can cause a crash, if a source is an external string, which already has been disposed. We had a similar problem in the past with DebugGetLoadedScripts.

BUG=http://crbug.com/23768
TEST=test-log/Issue23768

Committed: http://code.google.com/p/v8/source/detail?r=3027

[Søren Thygesen Gjesse, 2009-10-07 10:55:55]

http://codereview.chromium.org/269003/diff/1/3
File src/log.cc (right):

http://codereview.chromium.org/269003/diff/1/3#newcode1099
Line 1099: AssertNoAllocation no_alloc;
I suggest you move 
  AssertNoAllocation no_alloc;
into EnumerateCompiledFunctions.

http://codereview.chromium.org/269003/diff/1/6
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/269003/diff/1/6#newcode438
Line 438: class SimpleExternalFunc : public v8::String::ExternalStringResource {
SimpleExternalFunc -> SimpleExternalString

http://codereview.chromium.org/269003/diff/1/6#newcode470
Line 470: i_source->set_resource(0);
0 -> NULL

[mnaganov (inactive), 2009-10-07 11:40:51]

http://codereview.chromium.org/269003/diff/1/3
File src/log.cc (right):

http://codereview.chromium.org/269003/diff/1/3#newcode1099
Line 1099: AssertNoAllocation no_alloc;
On 2009/10/07 10:55:55, Søren Gjesse wrote:
> I suggest you move 
>   AssertNoAllocation no_alloc;
> into EnumerateCompiledFunctions.

Done. This simplifies code a lot, thanks!

http://codereview.chromium.org/269003/diff/1/6
File test/cctest/test-log.cc (right):

http://codereview.chromium.org/269003/diff/1/6#newcode438
Line 438: class SimpleExternalFunc : public v8::String::ExternalStringResource {
On 2009/10/07 10:55:55, Søren Gjesse wrote:
> SimpleExternalFunc -> SimpleExternalString

Done.

http://codereview.chromium.org/269003/diff/1/6#newcode470
Line 470: i_source->set_resource(0);
On 2009/10/07 10:55:55, Søren Gjesse wrote:
> 0 -> NULL

Done.

[Søren Thygesen Gjesse, 2009-10-07 12:18:53]

LGTM