Issue 269: Fix webkit.xcodeproj. Make it use our new xcconfig and common build director...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 269: Fix webkit.xcodeproj. Make it use our new xcconfig and common build director... (Closed)

Created:
12 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix webkit.xcodeproj. Make it use our new xcconfig and common build directory setup. Turn off headermaps and use explicit #include paths everywhere. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1815

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1937 lines, -5105 lines)			Patch
M	build/debug.xcconfig	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	third_party/libxml/libxml.xcodeproj/project.pbxproj	View	4 chunks	+13 lines, -11 lines	0 comments	Download
M	webkit/glue/webplugin_impl.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/port/bridge/mac/FrameMac.mm	View	1 chunk	+2 lines, -2 lines	0 comments	Download
D	webkit/tools/test_shell/mac/config.h	View	1 chunk	+0 lines, -10 lines	0 comments	Download
M	webkit/webkit.xcodeproj/project.pbxproj	View	79 chunks	+1917 lines, -5081 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

12 years, 3 months ago (2008-09-06 00:19:31 UTC) #1

Submitted as TBR.  Nobody's going to read the whole project file anyway, and I
want to get this out before someone else changes the project file and we have a
merge conflict.

There's a tiny bit more cleanup to do here, mostly around where the includes of
generated sources are defined (they're done in each target now but can largely
move to being a project setting).  Also, I need to restore or do something else
intelligent with the pcre target.

Note to self: I had to add -DWTF_CHANGES=1 to get WTF to build.

Another note to self: $(DIR_PORT)/platform/graphics and $(DIR_PORT)/platform
belong in the project-wide HEADER_SEARCH_PATHS but they can't be there until
port is fixed.  For now, they've been left out and then added to the port and
glue target HEADER_SEARCH_PATHS.

BUILDING_CHROMIUM__ is a bad name due to two leading underscores, I'll do a
separate change to fix that sometime.

Expand Messages | Collapse Messages