Issue 2685004: fix for issue 2610: add --yes flag to recovery_installer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2685004: fix for issue 2610: add --yes flag to recovery_installer (Closed)

Created:
10 years, 6 months ago by Tan Gao

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/recovery_installer.git

Visibility:
Public.

Description

fix for issue 2610: add --yes flag to recovery_installer - support auto-install of recovery image

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	recovery_install.conf	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Tan Gao

Hi Andrew, This flag is needed to fully automate recovery install (otherwise it'll be stuck ...

10 years, 6 months ago (2010-06-05 02:07:15 UTC) #1

adlr

10 years, 6 months ago (2010-06-07 16:36:38 UTC) #2

LGTM

On Fri, Jun 4, 2010 at 7:07 PM, <tgao@chromium.org> wrote:

> Reviewers: adlr,
>
> Message:
> Hi Andrew,
>
> This flag is needed to fully automate recovery install (otherwise it'll be
> stuck
> waiting for user input)
>
> Thanks,
> Tan
>
> Description:
> fix for issue 2610: add --yes flag to recovery_installer
>  - support auto-install of recovery image
>
> Please review this at http://codereview.chromium.org/2685004/show
>
> SVN Base: ssh://git@chromiumos-git/recovery_installer.git
>
> Affected files:
>  M recovery_install.conf
>
>
> Index: recovery_install.conf
> diff --git a/recovery_install.conf b/recovery_install.conf
> index
>
4c42ea98923cd27a2034a4bbdc96727aedb9f2f4..082954deaebcb3865a9fd7070cc6d6a56b7aa490
> 100644
> --- a/recovery_install.conf
> +++ b/recovery_install.conf
> @@ -12,7 +12,7 @@ start on started udev
>  # TODO(tgao): replace debug output and auto-shutdown with a friendly UI
>  script
>     # use "sh -x" to output extensive debug output to console for now
> -    sh -x /usr/sbin/chromeos-install --recovery --run_as_root
> +    sh -x /usr/sbin/chromeos-install --recovery --run_as_root --yes
>     # shut down and power off the device (with 1 minute delay)
>     shutdown -h +1
>  end script
>
>
>

Expand Messages | Collapse Messages