Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Issue 2685002: Added ANGLE to Windows build.... (Closed)

Created:
10 years, 6 months ago by apatrick_chromium
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Visibility:
Public.

Description

Added ANGLE to Windows build. Also added paths to DirectX SDK to common.gypi because ANGLE requires headers and libraries not part of the Windows Platform SDK. TEST=trybots BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49323

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -4 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M build/common.gypi View 3 chunks +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
apatrick_chromium
10 years, 6 months ago (2010-06-04 21:16:04 UTC) #1
M-A Ruel
There was a compile failure, was the relevant DEPS checked in yet? I want to ...
10 years, 6 months ago (2010-06-07 13:38:19 UTC) #2
apatrick
Yes the compilation failure on Windows is exactly as I expected. The DEPS file must ...
10 years, 6 months ago (2010-06-07 18:12:18 UTC) #3
apatrick_chromium
10 years, 6 months ago (2010-06-07 21:13:00 UTC) #4
I changed this a little. ANGLE is now a dependency of the "chromium_builder"
target and will only be built by trybots and buildbots and people specifically
building that target.

My reasoning is that I think ANGLE does not justify making the DirectX SDK a
prerequisite for building Chromium. ANGLE is only needed on Windows boxes
without a recent OpenGL driver installed. I think most developers will probably
prefer to install an OpenGL driver than the DirectX SDK. It's a much smaller
download.

It looks like the Windows trybot built ANGLE without errors.

Thanks.

Powered by Google App Engine
This is Rietveld 408576698