Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2577)

Unified Diff: chrome/browser/automation/ui_controls_linux.cc

Issue 268035: Implements tests for testing browser's overall key events handling behavior.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/keyboard_code_conversion_gtk.cc ('k') | chrome/browser/browser_focus_uitest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/automation/ui_controls_linux.cc
===================================================================
--- chrome/browser/automation/ui_controls_linux.cc (revision 28937)
+++ chrome/browser/automation/ui_controls_linux.cc (working copy)
@@ -197,23 +197,24 @@
(shift ? GDK_SHIFT_MASK : 0) |
(alt ? GDK_MOD1_MASK : 0);
- guint gdk_key = base::GdkKeyCodeForWindowsKeyCode(key);
+ guint gdk_key = base::GdkKeyCodeForWindowsKeyCode(key, shift);
rv = rv && SendKeyEvent(event_window, true, gdk_key, state);
rv = rv && SendKeyEvent(event_window, false, gdk_key, state);
if (alt) {
guint state = (control ? GDK_CONTROL_MASK : 0) |
- (shift ? GDK_SHIFT_MASK : 0);
+ (shift ? GDK_SHIFT_MASK : 0) | GDK_MOD1_MASK;
rv = rv && SendKeyEvent(event_window, false, GDK_Alt_L, state);
}
if (shift) {
rv = rv && SendKeyEvent(event_window, false, GDK_Shift_L,
- control ? GDK_CONTROL_MASK : 0);
+ (control ? GDK_CONTROL_MASK : 0) | GDK_SHIFT_MASK);
}
if (control)
- rv = rv && SendKeyEvent(event_window, false, GDK_Control_L, 0);
+ rv = rv && SendKeyEvent(event_window, false, GDK_Control_L,
+ GDK_CONTROL_MASK);
return rv;
}
« no previous file with comments | « base/keyboard_code_conversion_gtk.cc ('k') | chrome/browser/browser_focus_uitest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698