Issue 268: Fix binary patching for localized OS. Not sure how it was working till now....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 268: Fix binary patching for localized OS. Not sure how it was working till now.... (Closed)

Created:
12 years, 3 months ago by kuchhal

Modified:
9 years, 7 months ago

Reviewers:
huanr, Evan Martin, huanr

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix binary patching for localized OS. Not sure how it was working till now. BUG=1557 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1848

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -13 lines)			Patch
M	chrome/installer/setup/main.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	third_party/bspatch/mbspatch.h	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	third_party/bspatch/mbspatch.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

huanr

so the fix needs to change third_party/bspatch. are you going to submit your patch upstream?

12 years, 3 months ago (2008-09-07 05:25:51 UTC) #2

Evan Martin

Re: "Not sure how it was working till now." I imagine that the calls that ...

12 years, 3 months ago (2008-09-07 05:27:53 UTC) #3

huanr

12 years, 3 months ago (2008-09-08 04:27:19 UTC) #4

We need to update README.google in third_party\bspatch, to add some description
of this change. Otherwise, LGTM.

It would be ideal to have some regression test.

Expand Messages | Collapse Messages