Issue 2675007: Add OOBE/login html dialog.

Issue 2675007: Add OOBE/login html dialog. (Closed)

Created:
10 years, 6 months ago by Nikita (slow)

Modified:
9 years, 7 months ago

Reviewers:
whywhat

CC:
chromium-os-reviews_chromium.org, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Add OOBE/login html dialog. Use it for "Can't access your account" link. BUG= http://crosbug.com/3179 TEST=Open "Can't access your account" link from "New User" view. Committed: http://chrome-svn/viewvc/chromeos?view=rev&revision=49261

Patch Set 1 #

Patch Set 2 : refactor #

Patch Set 3 : refactor InitLink #

Patch Set 4 : removed test code #

Total comments: 4

Patch Set 5 : fixes #

Patch Set 6 : merge #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+184 lines, -10 lines)			Patch
M	chrome/app/generated_resources.grd	View	1 2 3 4 5	1 chunk	+6 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/login_html_dialog.h	View	1 2 3 4 5	1 chunk	+62 lines, -0 lines	0 comments	Download
A	chrome/browser/chromeos/login/login_html_dialog.cc	View	1	1 chunk	+63 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.h	View	1 2 3 4	5 chunks	+16 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/login/new_user_view.cc	View	1 2 3 4	10 chunks	+35 lines, -8 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	1 chunk	+2 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/2675007/diff/7001/8004 File chrome/browser/chromeos/login/new_user_view.cc (right): http://codereview.chromium.org/2675007/diff/7001/8004#newcode48 chrome/browser/chromeos/login/new_user_view.cc:48: static const char* kAccountRecoveryHelpUrl = You don't need ...

10 years, 6 months ago (2010-06-07 16:23:06 UTC) #2

Nikita (slow)

10 years, 6 months ago (2010-06-08 13:55:02 UTC) #3

http://codereview.chromium.org/2675007/diff/7001/8004
File chrome/browser/chromeos/login/new_user_view.cc (right):

http://codereview.chromium.org/2675007/diff/7001/8004#newcode48
chrome/browser/chromeos/login/new_user_view.cc:48: static const char*
kAccountRecoveryHelpUrl =
On 2010/06/07 16:23:07, whywhat wrote:
> You don't need static here. It's better to use array type than pointer (fix
the
> definition above too, plz).

Done.

http://codereview.chromium.org/2675007/diff/7001/8004#newcode334
chrome/browser/chromeos/login/new_user_view.cc:334: GetNativeWindow(),
On 2010/06/07 16:23:07, whywhat wrote:
> Do we need a public method for just one call at one place?
> Add a variable and inline the code here perhaps?

I've made it private. It could be reused for other dialogs from here.

Expand Messages | Collapse Messages