Issue 2675003: [Mac] Remove dead underlayImage_ from GradientButtonCell.

Issue 2675003: [Mac] Remove dead underlayImage_ from GradientButtonCell. (Closed)

Created:
10 years, 6 months ago by Scott Hess - ex-Googler

Modified:
9 years, 6 months ago

Reviewers:
Avi (use Gerrit), viettrungluu

CC:
chromium-reviews, John Grabowski, pam+watch_chromium.org, ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

[Mac] Remove dead underlayImage_ from GradientButtonCell. AFAICT was being used by the star button, which is now a page action. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49282

Patch Set 1 #

Total comments: 4

Patch Set 2 : Trung's nits. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -36 lines)			Patch
	M	chrome/browser/cocoa/gradient_button_cell.h	View	1	3 chunks	+1 line, -6 lines	0 comments	Download
	M	chrome/browser/cocoa/gradient_button_cell.mm	View	1	6 chunks	+1 line, -30 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Scott Hess - ex-Googler

Figured that it wasn't flipping worth fixing dead code.

10 years, 6 months ago (2010-06-04 19:19:22 UTC) #1

Avi (use Gerrit)

This is actually my old code, and yes, it was used to draw the chewy ...

10 years, 6 months ago (2010-06-04 19:26:33 UTC) #2

viettrungluu

lgtm http://codereview.chromium.org/2675003/diff/1/2 File chrome/browser/cocoa/gradient_button_cell.h (right): http://codereview.chromium.org/2675003/diff/1/2#newcode1 chrome/browser/cocoa/gradient_button_cell.h:1: // Copyright (c) 2009 The Chromium Authors. All ...

10 years, 6 months ago (2010-06-04 20:26:03 UTC) #3

Scott Hess - ex-Googler

10 years, 6 months ago (2010-06-09 17:38:36 UTC) #4

thanks!

http://codereview.chromium.org/2675003/diff/1/2
File chrome/browser/cocoa/gradient_button_cell.h (right):

http://codereview.chromium.org/2675003/diff/1/2#newcode1
chrome/browser/cocoa/gradient_button_cell.h:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2010/06/04 20:26:03, viettrungluu wrote:
> 2010
> 
> (there's so little for me to pick on ... but I can't let a review go by
without
> saying something)

Done.

http://codereview.chromium.org/2675003/diff/1/3
File chrome/browser/cocoa/gradient_button_cell.mm (right):

http://codereview.chromium.org/2675003/diff/1/3#newcode1
chrome/browser/cocoa/gradient_button_cell.mm:1: // Copyright (c) 2009 The
Chromium Authors. All rights reserved.
On 2010/06/04 20:26:03, viettrungluu wrote:
> 2010

Done.

Expand Messages | Collapse Messages