Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Unified Diff: chrome/browser/autofill/autofill_address_model_mac.h

Issue 2673006: AutoFill Profiles dialog implemented according to new mocks on Mac (Closed)
Patch Set: Revisions based on review comments. Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/nibs/AutoFillDialog.xib ('k') | chrome/browser/autofill/autofill_address_model_mac.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/autofill/autofill_address_model_mac.h
diff --git a/chrome/browser/autofill/autofill_address_model_mac.h b/chrome/browser/autofill/autofill_address_model_mac.h
index 9ea052f6d009487268ed51a0ddd43f08bd326c8e..611fc7fe93495c9554fb11ccdd9e839262770ef1 100644
--- a/chrome/browser/autofill/autofill_address_model_mac.h
+++ b/chrome/browser/autofill/autofill_address_model_mac.h
@@ -12,7 +12,6 @@ class AutoFillProfile;
// A "model" class used with bindings mechanism and the
// |AutoFillAddressViewController| to achieve the form-like view
// of autofill data in the Chrome options UI.
-// Note that |summary| is a derived property.
// Model objects are initialized from a given profile using the designated
// initializer |initWithProfile:|.
// Users of this class must be prepared to handle nil string return values.
@@ -22,9 +21,7 @@ class AutoFillProfile;
@private
// These are not scoped_nsobjects because we use them via KVO/bindings.
NSString* label_;
- NSString* firstName_;
- NSString* middleName_;
- NSString* lastName_;
+ NSString* fullName_;
NSString* email_;
NSString* companyName_;
NSString* addressLine1_;
@@ -37,14 +34,8 @@ class AutoFillProfile;
NSString* faxWholeNumber_;
}
-// |summary| is a derived property based on |firstName|, |lastName| and
-// |addressLine1|. KVO observers receive change notifications for |summary|
-// when any of these properties change.
-@property (readonly) NSString* summary;
@property (nonatomic, copy) NSString* label;
-@property (nonatomic, copy) NSString* firstName;
-@property (nonatomic, copy) NSString* middleName;
-@property (nonatomic, copy) NSString* lastName;
+@property (nonatomic, copy) NSString* fullName;
@property (nonatomic, copy) NSString* email;
@property (nonatomic, copy) NSString* companyName;
@property (nonatomic, copy) NSString* addressLine1;
« no previous file with comments | « chrome/app/nibs/AutoFillDialog.xib ('k') | chrome/browser/autofill/autofill_address_model_mac.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698