Add pylintrc and fix style for many scripts.

gcl.py

 #!/usr/bin/python
 # Copyright (c) 2006-2009 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """\
 Wrapper script around Rietveld's upload.py that simplifies working with groups
 of files.
 """
 
 import getpass
 import os
 import random
 import re
-import shutil
 import string
 import subprocess
 import sys
 import tempfile
 import time
 from third_party import upload
 import urllib2
 
 __pychecker__ = 'unusednames=breakpad'
 import breakpad
@@ skipping 94 matching lines @@
 def GetCachedFile(filename, max_age=60*60*24*3, use_root=False):
   """Retrieves a file from the repository and caches it in GetCacheDir() for
   max_age seconds.
 
   use_root: If False, look up the arborescence for the first match, otherwise go
             directory to the root repository.
 
   Note: The cache will be inconsistent if the same file is retrieved with both
         use_root=True and use_root=False. Don't be stupid.
   """
-  global FILES_CACHE
   if filename not in FILES_CACHE:
     # Don't try to look up twice.
     FILES_CACHE[filename] = None
     # First we check if we have a cached version.
     try:
       cached_file = os.path.join(GetCacheDir(), filename)
     except gclient_utils.Error:
       return None
     if (not os.path.exists(cached_file) or
         (time.time() - os.stat(cached_file).st_mtime) > max_age):
@@ skipping 25 matching lines @@
       content = gclient_utils.FileRead(cached_file, 'r')
     # Keep the content cached in memory.
     FILES_CACHE[filename] = content
   return FILES_CACHE[filename]
 
 
 def GetCodeReviewSetting(key):
   """Returns a value for the given key for this repository."""
   # Use '__just_initialized' as a flag to determine if the settings were
   # already initialized.
-  global CODEREVIEW_SETTINGS
   if '__just_initialized' not in CODEREVIEW_SETTINGS:
     settings_file = GetCachedFile(CODEREVIEW_SETTINGS_FILE)
     if settings_file:
       for line in settings_file.splitlines():
         if not line or line.startswith("#"):
           continue
         k, v = line.split(": ", 1)
         CODEREVIEW_SETTINGS[k] = v
     CODEREVIEW_SETTINGS.setdefault('__just_initialized', None)
   return CODEREVIEW_SETTINGS.get(key, "")
 
 
 def Warn(msg):
   ErrorExit(msg, exit=False)
 
 
-def ErrorExit(msg, exit=True):
+def ErrorExit(msg, do_exit=True):
   """Print an error message to stderr and optionally exit."""
-  print >>sys.stderr, msg
-  if exit:
+  print >> sys.stderr, msg
+  if do_exit:
     sys.exit(1)
 
 
 def RunShellWithReturnCode(command, print_output=False):
   """Executes a command and returns the output and the return code."""
   # Use a shell for subcommands on Windows to get a PATH search, and because svn
   # may be a batch file.
   use_shell = sys.platform.startswith("win")
   p = subprocess.Popen(command, stdout=subprocess.PIPE,
                        stderr=subprocess.STDOUT, shell=use_shell,
@@ skipping 562 matching lines @@
 
     # Watchlist processing -- CC people interested in this changeset
     # http://dev.chromium.org/developers/contributing-code/watchlists
     if not no_watchlists:
       import watchlists
       watchlist = watchlists.Watchlists(change_info.GetLocalRoot())
       watchers = watchlist.GetWatchersForPaths(change_info.GetFileNames())
 
     cc_list = GetCodeReviewSetting("CC_LIST")
     if not no_watchlists and watchers:
-        # Filter out all empty elements and join by ','
-        cc_list = ','.join(filter(None, [cc_list] + watchers))
+      # Filter out all empty elements and join by ','
+      cc_list = ','.join(filter(None, [cc_list] + watchers))
     if cc_list:
       upload_arg.append("--cc=" + cc_list)
     upload_arg.append("--description_file=" + desc_file + "")
     if change_info.description:
       subject = change_info.description[:77]
       if subject.find("\r\n") != -1:
         subject = subject[:subject.find("\r\n")]
       if subject.find("\n") != -1:
         subject = subject[:subject.find("\n")]
       if len(change_info.description) > 77:
@@ skipping 380 matching lines @@
   cmd = ['svn', 'diff']
   cmd.extend([os.path.join(root, x) for x in files])
   cmd.extend(args)
   return RunShellWithReturnCode(cmd, print_output=True)[1]
 
 
 @no_args
 def CMDsettings():
   """Prints code review settings for this checkout."""
   # Force load settings
-  GetCodeReviewSetting("UNKNOWN");
+  GetCodeReviewSetting("UNKNOWN")
   del CODEREVIEW_SETTINGS['__just_initialized']
   print '\n'.join(("%s: %s" % (str(k), str(v))
                     for (k,v) in CODEREVIEW_SETTINGS.iteritems()))
   return 0
 
 
 @need_change
 def CMDdescription(change_info):
   """Prints the description of the specified change to stdout."""
   print change_info.description
@@ skipping 125 matching lines @@
     argv = ['help']
   command = Command(argv[0])
   if command:
     return command(argv[1:])
   # Unknown command, try to pass that to svn
   return CMDpassthru(argv)
 
 
 if __name__ == "__main__":
   sys.exit(main(sys.argv[1:]))