Issue 2673002: Add pylintrc and fix style for many scripts.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2673002: Add pylintrc and fix style for many scripts. (Closed)

Created:
10 years, 6 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews

Visibility:
Public.

Add pylintrc and fix style for many scripts. Fix a bug in scm.SVN.DiffItem() Reduce variable aliasing, fix alignments, etc. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48943

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+427 lines, -193 lines)			Patch
M	drover.py	View		20 chunks	+78 lines, -86 lines	0 comments	Download
M	gcl.py	View		6 chunks	+6 lines, -9 lines	0 comments	Download
M	gclient.py	View	1	2 chunks	+45 lines, -44 lines	0 comments	Download
M	gclient_scm.py	View	1 2	15 chunks	+22 lines, -32 lines	0 comments	Download
M	gclient_utils.py	View		3 chunks	+4 lines, -4 lines	0 comments	Download
A	pylintrc	View		1 chunk	+253 lines, -0 lines	0 comments	Download
	scm.py	View		13 chunks	+19 lines, -18 lines	0 comments	Download

Total messages: 2 (0 generated)

M-A Ruel

Somewhat braindead change but useful with the changes I plan to do. At least I ...

10 years, 6 months ago (2010-06-04 17:03:32 UTC) #1

bradn

10 years, 6 months ago (2010-06-04 17:16:38 UTC) #2

LGTM (though rubberstamp on the pylintrc file, looks plausible though).