Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 267117: Untangle some #include dependencies.... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Untangle some #include dependencies. "jsregexp.h" and "jump-target.h" required "macro-assembler.h" to always be included first. Instead the include of "macro-assembler.h" has moved into those header files. "dateparser-inl.h" required "dateparser.h" to always be included first. Instead the include of "dateparser.h" has moved into "dateparser-inl.h". Committed: http://code.google.com/p/v8/source/detail?r=3074

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M src/ast.h View 1 chunk +2 lines, -3 lines 0 comments Download
M src/dateparser-inl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/jsregexp.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/jsregexp.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M src/jump-target.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/objects-debug.cc View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-15 14:30:48 UTC) #1
Erik Corry
11 years, 2 months ago (2009-10-15 14:58:21 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698