src/x64/debug-x64.cc - Issue 267116: Fix X64 build in the case that debugger support is disabled. Change function...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/x64/debug-x64.cc

Issue 267116: Fix X64 build in the case that debugger support is disabled. Change function... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/x64/debug-x64.cc

===================================================================

--- src/x64/debug-x64.cc (revision 3070)

+++ src/x64/debug-x64.cc (working copy)

@@ -39,10 +39,7 @@

bool Debug::IsDebugBreakAtReturn(v8::internal::RelocInfo* rinfo) {

ASSERT(RelocInfo::IsJSReturn(rinfo->rmode()));

- // 11th byte of patch is 0x49 (REX.WB byte of computed jump/call to r10),

- // 11th byte of JS return is 0xCC (int3).

- ASSERT(*(rinfo->pc() + 10) == 0x49 || *(rinfo->pc() + 10) == 0xCC);

- return (*(rinfo->pc() + 10) != 0xCC);

+ return rinfo->IsPatchedReturnSequence();

}

#define __ ACCESS_MASM(masm)

« no previous file with comments | « src/x64/assembler-x64-inl.h ('k') | no next file » | no next file with comments »