Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Side by Side Diff: chrome/browser/utility_process_host_unittest.cc

Issue 267102: Better code to determine the framework and helper app paths (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/utility_process_host.h" 5 #include "chrome/browser/utility_process_host.h"
6 6
7 #include "base/file_path.h" 7 #include "base/file_path.h"
8 #include "base/file_util.h" 8 #include "base/file_util.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/message_loop.h" 10 #include "base/message_loop.h"
(...skipping 61 matching lines...) Expand 10 before | Expand all | Expand 10 after
72 TestUtilityProcessHost(TestUtilityProcessHostClient* client, 72 TestUtilityProcessHost(TestUtilityProcessHostClient* client,
73 MessageLoop* loop_io, 73 MessageLoop* loop_io,
74 ResourceDispatcherHost* rdh) 74 ResourceDispatcherHost* rdh)
75 : UtilityProcessHost(rdh, client, loop_io) { 75 : UtilityProcessHost(rdh, client, loop_io) {
76 } 76 }
77 77
78 protected: 78 protected:
79 virtual FilePath GetUtilityProcessCmd() { 79 virtual FilePath GetUtilityProcessCmd() {
80 FilePath exe_path; 80 FilePath exe_path;
81 PathService::Get(base::DIR_EXE, &exe_path); 81 PathService::Get(base::DIR_EXE, &exe_path);
82 exe_path = exe_path.AppendASCII(WideToASCII( 82 exe_path = exe_path.Append(chrome::kHelperProcessExecutablePath);
83 chrome::kHelperProcessExecutablePath));
84 return exe_path; 83 return exe_path;
85 } 84 }
86 85
87 virtual bool UseSandbox() { 86 virtual bool UseSandbox() {
88 return false; 87 return false;
89 } 88 }
90 89
91 private: 90 private:
92 }; 91 };
93 92
(...skipping 57 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 temp_extension_dir.AppendASCII("theme.crx")); 150 temp_extension_dir.AppendASCII("theme.crx"));
152 observer.RunUntilClose(process_host->id()); 151 observer.RunUntilClose(process_host->id());
153 EXPECT_TRUE(client->success()); 152 EXPECT_TRUE(client->success());
154 153
155 // Clean up the temp dir. 154 // Clean up the temp dir.
156 file_util::Delete(temp_extension_dir, true); 155 file_util::Delete(temp_extension_dir, true);
157 } 156 }
158 #endif 157 #endif
159 158
160 } // namespace 159 } // namespace
OLDNEW
« no previous file with comments | « no previous file | chrome/chrome.gyp » ('j') | chrome/chrome.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698