chrome/browser/cocoa/toolbar_controller.mm - Issue 267082: Makes it so when NSViewControllers go away that they remove their views from ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/cocoa/toolbar_controller.mm

Issue 267082: Makes it so when NSViewControllers go away that they remove their views from ... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/cocoa/toolbar_controller.mm

===================================================================

--- chrome/browser/cocoa/toolbar_controller.mm (revision 28822)

+++ chrome/browser/cocoa/toolbar_controller.mm (working copy)

@@ -128,6 +128,9 @@

if (trackingArea_.get())

[[self view] removeTrackingArea:trackingArea_.get()];

+ // Remove our view from its superview so it doesn't attempt to reference

+ // it when the controller is gone.

+ [[self view] removeFromSuperview];

[super dealloc];

}

« no previous file with comments | « chrome/browser/cocoa/tab_controller.mm ('k') | no next file » | no next file with comments »