Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(346)

Issue 267059: Make svn password prompt available during setup.... (Closed)

Created:
11 years, 2 months ago by chase
Modified:
9 years, 7 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews_googlegroups.com, M-A Ruel
Visibility:
Public.

Description

Make svn password prompt available during setup. Allow the user to interact with the svn password prompt if needed. Verify the svn server is reachable before proceeding. Clean extra UI issues up. Readability fixes. BUG=none TEST=prompted for a svn password if ~/.subversion/auth is empty, bad svn server causes early timeout Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29552

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -22 lines) Patch
M create-chromium-git-src View 9 chunks +28 lines, -22 lines 2 comments Download

Messages

Total messages: 3 (0 generated)
chase
Looking to get feedback on/land this patch which was sitting in my depot_tools checkout.
11 years, 2 months ago (2009-10-12 21:23:15 UTC) #1
M-A Ruel
lgtm http://codereview.chromium.org/267059/diff/1/2 File create-chromium-git-src (right): http://codereview.chromium.org/267059/diff/1/2#newcode83 Line 83: (cd "${TMP}" && git svn init --username="${EMAIL}" ...
11 years, 2 months ago (2009-10-12 22:09:00 UTC) #2
chase
11 years, 2 months ago (2009-10-20 20:05:14 UTC) #3
http://codereview.chromium.org/267059/diff/1/2
File create-chromium-git-src (right):

http://codereview.chromium.org/267059/diff/1/2#newcode83
Line 83: (cd "${TMP}" && git svn init --username="${EMAIL}" --prefix=origin/ \
On 2009/10/12 22:09:02, Marc-Antoine Ruel wrote:
> why not svn ls?

Tried in an earlier version, couldn't get the exact form of the SVN path needed
that would satisfy git svn init.  Found calling git svn init to be the simplest
solution to fix the main issue.

Powered by Google App Engine
This is Rietveld 408576698