Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9700)

Unified Diff: chrome/common/extensions/extension_resource.h

Issue 267051: Minimize dependency of user scripts.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/extensions/extension_resource.h
===================================================================
--- chrome/common/extensions/extension_resource.h (revision 29458)
+++ chrome/common/extensions/extension_resource.h (working copy)
@@ -22,6 +22,12 @@
// *** MIGHT HIT FILESYSTEM. Do not call on UI thread! ***
const FilePath& GetFilePath() const;
+ // Static version to avoid creating an instance of ExtensionResource
+ // when all we want is the localization code.
+ // *** MIGHT HIT FILESYSTEM. Do not call on UI thread! ***
+ static FilePath GetFilePath(const FilePath& extension_root,
+ const FilePath& relative_path);
+
// Getters
const FilePath& extension_root() const { return extension_root_; }
const FilePath& relative_path() const { return relative_path_; }
@@ -31,11 +37,6 @@
bool ComparePathWithDefault(const FilePath& path) const;
private:
- // Returns normalized full path to the resource.
- // Resource doesn't have to exist.
- FilePath CombinePathsSafely(const FilePath& extension_root,
- const FilePath& relative_path) const;
-
// Extension root.
FilePath extension_root_;

Powered by Google App Engine
This is Rietveld 408576698