Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6475)

Unified Diff: chrome/browser/extensions/user_script_master.cc

Issue 267051: Minimize dependency of user scripts.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/user_script_master.cc
===================================================================
--- chrome/browser/extensions/user_script_master.cc (revision 29458)
+++ chrome/browser/extensions/user_script_master.cc (working copy)
@@ -136,7 +136,8 @@
static bool LoadScriptContent(UserScript::File* script_file) {
std::string content;
- FilePath path = script_file->resource().GetFilePath();
+ const FilePath& path = ExtensionResource::GetFilePath(
+ script_file->extension_root(), script_file->relative_path());
if (path.empty() || !file_util::ReadFileToString(path, &content)) {
LOG(WARNING) << "Failed to load user script file: " << path.value();
return false;
@@ -168,8 +169,8 @@
// Push single js file in this UserScript.
GURL url(std::string(chrome::kUserScriptScheme) + ":/" +
net::FilePathToFileURL(file).ExtractFileName());
- ExtensionResource resource(script_dir, file.BaseName());
- user_script.js_scripts().push_back(UserScript::File(resource, url));
+ user_script.js_scripts().push_back(UserScript::File(
+ script_dir, file.BaseName(), url));
UserScript::File& script_file = user_script.js_scripts().back();
if (!LoadScriptContent(&script_file))
result->pop_back();

Powered by Google App Engine
This is Rietveld 408576698