test/cctest/test-macro-assembler-x64.cc - Issue 267049: Removed 31-bit smis.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-macro-assembler-x64.cc

Issue 267049: Removed 31-bit smis. (Closed)

Patch Set: Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: test/cctest/test-macro-assembler-x64.cc

diff --git a/test/cctest/test-macro-assembler-x64.cc b/test/cctest/test-macro-assembler-x64.cc

index 27a394642ae49ae21712acccecf0b2ca0f4915ee..9c1197ffd81dd1c58a347c8b7389347bd4cc7cd6 100755

--- a/test/cctest/test-macro-assembler-x64.cc

+++ b/test/cctest/test-macro-assembler-x64.cc

@@ -1071,7 +1071,7 @@ TEST(SmiMul) {

void TestSmiDiv(MacroAssembler* masm, Label* exit, int id, int x, int y) {

bool division_by_zero = (y == 0);

bool negative_zero = (x == 0 && y < 0);

-#ifdef V8_LONG_SMI

+#ifdef V8_TARGET_ARCH_X64

bool overflow = (x == Smi::kMinValue && y < 0); // Safe approx. used.

#else

bool overflow = (x == Smi::kMinValue && y == -1);

« no previous file with comments | « test/cctest/test-heap.cc ('k') | no next file » | no next file with comments »