Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 267004: Prepare push to trunk. Now working on version 1.3.16. (Closed)

Created:
11 years, 2 months ago by Søren Thygesen Gjesse
Modified:
9 years, 7 months ago
Reviewers:
William Hesse
CC:
v8-dev
Visibility:
Public.

Description

Prepare push to trunk. Now working on version 1.3.16. Committed: http://code.google.com/p/v8/source/detail?r=3029

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M ChangeLog View 1 1 chunk +8 lines, -0 lines 0 comments Download
M src/version.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Thygesen Gjesse
11 years, 2 months ago (2009-10-07 12:58:57 UTC) #1
William Hesse
LGTM. http://codereview.chromium.org/267004/diff/1/3 File ChangeLog (right): http://codereview.chromium.org/267004/diff/1/3#newcode3 Line 3: Expand the maximum size of the code ...
11 years, 2 months ago (2009-10-07 13:36:41 UTC) #2
Søren Thygesen Gjesse
11 years, 2 months ago (2009-10-07 13:40:48 UTC) #3
http://codereview.chromium.org/267004/diff/1/3
File ChangeLog (right):

http://codereview.chromium.org/267004/diff/1/3#newcode3
Line 3: Expand the maximum size of the code space  to 512MB fir 64-bit mode.
On 2009/10/07 13:36:41, William Hesse wrote:
> for, not fir.

Done, also removed one of the spaces before "to".

Powered by Google App Engine
This is Rietveld 408576698