Separate out some more ICU from base and into base/i18n....

Separate out some more ICU from base and into base/i18n.

This moves string_util_icu. I moved the number formatting function into
base/i18n/number_formatting and just removed the other function in
string_util_icu which was TrimWhitespaceUTF8. It is only used in a few places
and isn't actually helpful (and the fact that it round-trips through UTF-16 is
better for the caller to see).

This takes out the sorting from the FileEnumerator. The comment says the
sorting is not guaranteed. I moved it into file_util_icu as a standalone
function for callers of FileEnumerator to call manually if they need sorted
results. I modified the directory lister to use this sorting instead, and filed
a bug on doing more optimal JS-based sorting.

TEST=none
BUG=none

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28405

[brettw, 2009-10-07 03:50:13]

This makes Linux & Mac directory lists unsorted. I'm checking with Darin about
this and will possibly write a sorting pass into the directory lister before
checkin to avoid breaking this.

[darin (slow to review), 2009-10-07 04:41:08]

I'm fine with either doing sorting in the DirectoryLister or in JavaScript
within the directory viewer itself.  I've always thought it would be nice to be
able to click on the columns to sort.

[Sean Parent, 2009-10-07 19:32:18]

You have a couple of lint errors and I had a couple of minor comments.

Otherwise - LGTM.

http://codereview.chromium.org/267001/diff/100/4032
File chrome/browser/task_manager.h (right):

http://codereview.chromium.org/267001/diff/100/4032#newcode318
Line 318: // Given a string containing a number, this function returns the
formatted
The comment doesn't appear to have been updated with the function.

http://codereview.chromium.org/267001/diff/100/4039
File net/base/directory_lister.cc (right):

http://codereview.chromium.org/267001/diff/100/4039#newcode28
Line 28: if (!data.empty()) {
Minor - I don't like double negatives where they can be avoided. You might also
consider avoiding the else clause with an early return:

if (data.empty()) {
  lister->OnDone(error);
  return;
}

lister->OnReceivedData(...);