Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(540)

Unified Diff: net/base/keygen_handler_nss.cc

Issue 2668005: Bring the handling of <keygen> and support for the application/x-x509-user-ce... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: Whitespace/style Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/base/keygen_handler_mac.cc ('k') | net/base/keygen_handler_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/base/keygen_handler_nss.cc
===================================================================
--- net/base/keygen_handler_nss.cc (revision 49024)
+++ net/base/keygen_handler_nss.cc (working copy)
@@ -52,21 +52,6 @@
{ 0, }
};
-void StoreKeyLocationInCache(const SECItem& public_key_info,
- PK11SlotInfo *slot) {
- KeygenHandler::Cache* cache = KeygenHandler::Cache::GetInstance();
- KeygenHandler::KeyLocation key_location;
- const char* slot_name = PK11_GetSlotName(slot);
- key_location.slot_name.assign(slot_name);
- cache->Insert(std::string(reinterpret_cast<char*>(public_key_info.data),
- public_key_info.len), key_location);
-}
-
-bool KeygenHandler::KeyLocation::Equals(
- const net::KeygenHandler::KeyLocation& location) const {
- return slot_name == location.slot_name;
-}
-
// This function is largely copied from the Firefox's
// <keygen> implementation in security/manager/ssl/src/nsKeygenHandler.cpp
// FIXME(gauravsh): Do we need a copy of the Mozilla license here?
@@ -210,8 +195,6 @@
goto failure;
}
- StoreKeyLocationInCache(spkiItem, slot);
-
failure:
if (!isSuccess) {
LOG(ERROR) << "SSL Keygen failed!";
« no previous file with comments | « net/base/keygen_handler_mac.cc ('k') | net/base/keygen_handler_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698