Issue 2665001: Count Mark-Compact/Mark-Sweep collections only after compaction decision was made

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2665001: Count Mark-Compact/Mark-Sweep collections only after compaction decision was made (Closed)

Created:
10 years, 6 months ago by Vyacheslav Egorov (Chromium)

Modified:
9 years, 7 months ago

Reviewers:
Mark Lam, Mads Ager (chromium)

CC:
v8-dev

Visibility:
Public.

Description

Count Mark-Compact/Mark-Sweep collections only after compaction decision was made Committed: http://code.google.com/p/v8/source/detail?r=4811

Patch Set 2 : set full gc count to a correct value #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
	M	src/heap.cc	View	1	1 chunk	+7 lines, -6 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Mark Lam

http://codereview.chromium.org/2665001/diff/1/2 File src/heap.cc (right): http://codereview.chromium.org/2665001/diff/1/2#newcode660 src/heap.cc:660: tracer->set_full_gc_count(mc_count_); Drive by comment: shouldn't this line be moved ...

10 years, 6 months ago (2010-06-04 07:46:05 UTC) #2

Vyacheslav Egorov (Chromium)

10 years, 6 months ago (2010-06-04 07:49:40 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 2665001: Count Mark-Compact/Mark-Sweep collections only after compaction decision was made (Closed)

Description

Patch Set 1 #

Patch Set 2 : set full gc count to a correct value #

Messages