Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(411)

Unified Diff: chrome/browser/browser_process_impl.h

Issue 2664004: Win: Fix race possible during startup before first Browser is created. (Closed) Base URL: git://codf21.jail/chromium.git
Patch Set: remove no-longer true comment from process_singleton_win Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/browser_process_impl.h
diff --git a/chrome/browser/browser_process_impl.h b/chrome/browser/browser_process_impl.h
index 703d70c58384f04cef73364a5e9db338a58b904e..186618faad84032cd74398dde784d79d1bcfe118 100644
--- a/chrome/browser/browser_process_impl.h
+++ b/chrome/browser/browser_process_impl.h
@@ -171,7 +171,7 @@ class BrowserProcessImpl : public BrowserProcess, public NonThreadSafe {
virtual bool IsShuttingDown() {
DCHECK(CalledOnValidThread());
- return 0 == module_ref_count_;
+ return did_start_ && 0 == module_ref_count_;
}
virtual printing::PrintJobManager* print_job_manager();
@@ -303,6 +303,7 @@ class BrowserProcessImpl : public BrowserProcess, public NonThreadSafe {
scoped_ptr<NotificationService> main_notification_service_;
unsigned int module_ref_count_;
+ bool did_start_;
// Ensures that all the print jobs are finished before closing the browser.
scoped_ptr<printing::PrintJobManager> print_job_manager_;
« no previous file with comments | « no previous file | chrome/browser/browser_process_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698