Issue 2664004: Win: Fix race possible during startup before first Browser is created.

Issue 2664004: Win: Fix race possible during startup before first Browser is created. (Closed)

Created:
10 years, 6 months ago by mattm

Modified:
9 years, 7 months ago

Reviewers:
MAD, robertshield, cpu_(ooo_6.6-7.5)

CC:
chromium-reviews, Paweł Hajdan Jr., ben+cc_chromium.org

Base URL:
git://codf21.jail/chromium.git

Visibility:
Public.

Description

Win: Fix race possible during startup before first Browser is created. BUG=38572 TEST=uitest, also "chrome/Debug/chrome.exe & chrome/Debug/chrome.exe" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49348

Patch Set 1 #

Patch Set 2 : remove crbug link #

Patch Set 3 : don't enable the test yet #

Patch Set 4 : remove no-longer true comment from process_singleton_win #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -4 lines)			Patch
M	chrome/browser/browser_process_impl.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/browser_process_impl.cc	View	1 2	2 chunks	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/process_singleton_win.cc	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

Nice. Make sure that you don't break the 'first run' mode, you can test with ...

10 years, 6 months ago (2010-06-04 23:28:06 UTC) #2

mattm

Tested with first run, looks okay. Also, I found some other issues with the test ...

10 years, 6 months ago (2010-06-10 00:19:55 UTC) #3

robertshield

10 years, 6 months ago (2010-06-10 00:23:28 UTC) #4

On 2010/06/10 00:19:55, mattm wrote:
> Tested with first run, looks okay.  Also, I found some other issues with the
> test so I'd like to submit this CL without the re-enabling the test, and send
> another follow up CL with fixes to the test.
> Also, remembered to remove the comment from OnCopyData about IsShuttingDown.
> 
> On 2010/06/04 23:28:06, cpu wrote:
> > Nice. Make sure that you don't break the 'first run' mode, you can test with
> > --first-run. For example in process_singleton_win.cc OnCopyData() is called
> > before any addref.
> > 
> > But I don't see anything in principle with your approach thus lgtm
> > 
> > On 2010/06/04 22:39:08, mattm wrote:
> > >

LGTM too.

Expand Messages | Collapse Messages