Issue 2664003: s/org.moblin.connman/org.chromium.flimflam/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2664003: s/org.moblin.connman/org.chromium.flimflam/ (Closed)

Created:
10 years, 6 months ago by petkov

Modified:
9 years, 7 months ago

Reviewers:
Sam Leffler

CC:
chromium-os-reviews_chromium.org

Base URL:
ssh://git@chromiumos-git/metrics.git

Visibility:
Public.

Description

s/org.moblin.connman/org.chromium.flimflam/

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+5 lines, -5 lines)			Patch
	M	metrics_daemon.cc	View		3 chunks	+4 lines, -4 lines	0 comments	Download
	M	metrics_daemon_test.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Sam Leffler

10 years, 6 months ago (2010-06-04 20:56:05 UTC) #2

LGTM

Might want to restructure things a bit in a separate CL to consolidate the
string in one place.  This stuff is defined in flimflam/include/dbus.h but not
sure how easy it is to use that file.

Expand Messages | Collapse Messages