Issue 266021: MD5 header cleanup for lint and items brought up when reviewing code based on...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266021: MD5 header cleanup for lint and items brought up when reviewing code based on... (Closed)

Created:
11 years, 2 months ago by fbarchard

Modified:
9 years, 7 months ago

Reviewers:
awong

CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

MD5 header cleanup for lint and items brought up when reviewing code based on md5. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28433

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Patch Set 4 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+24 lines, -16 lines)			Patch
	M	base/md5.h	View	1 2 3	3 chunks	+24 lines, -16 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

awong

11 years, 2 months ago (2009-10-08 19:39:14 UTC) #2

LGTM

http://codereview.chromium.org/266021/diff/2002/3001
File base/md5.h (right):

http://codereview.chromium.org/266021/diff/2002/3001#newcode10
Line 10: // MD5 stands for Message Digest algorithm 5
Add a period at the end of this sentence please. :)

http://codereview.chromium.org/266021/diff/2002/3001#newcode15
Line 15: // http://en.wikipedia.org/wiki/MD5
Indent 2 spaces since it's after a "See Also:".  Alternately, put it on the same
line.

Expand Messages | Collapse Messages