Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 266020: Use static_cast in LinkNode<T>::value() so that it works with... (Closed)

Created:
11 years, 2 months ago by darin (slow to review)
Modified:
9 years, 7 months ago
Reviewers:
eroman
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Use static_cast in LinkNode<T>::value() so that it works with multiple inheritance. R=eroman BUG=none TEST=LinkedList.MultipleInheritanceNode Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28439

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -3 lines) Patch
M base/linked_list.h View 1 chunk +2 lines, -2 lines 0 comments Download
M base/linked_list_unittest.cc View 3 chunks +17 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
darin (slow to review)
11 years, 2 months ago (2009-10-08 18:07:29 UTC) #1
eroman
11 years, 2 months ago (2009-10-08 18:33:50 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698