Mac: Resize status bubble when window is resized.

Mac: Resize status bubble when window is resized.

BUG=22956
TEST=Load a (slow-loading) web site so that a status bubble will appear and be visible for a while. While the status bubble is visible, resize the window. The status bubble should move and/or resize appropriately.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28448

[Avi (use Gerrit), 2009-10-08 18:10:32]

http://codereview.chromium.org/266018/diff/1/6
File chrome/browser/cocoa/status_bubble_mac.mm (right):

http://codereview.chromium.org/266018/diff/1/6#newcode230
Line 230: void StatusBubbleMac::Resize() {
1. Can we merge this sizing with the sizing done in Create(), above? Don't like
that it's done in two places.

2. The name implies that it's a request to resize the bubble rather than that
the parent changed. How about Reposition?

[viettrungluu, 2009-10-08 18:36:35]

Thanks, Avi. Please re-review.

http://codereview.chromium.org/266018/diff/1/6
File chrome/browser/cocoa/status_bubble_mac.mm (right):

http://codereview.chromium.org/266018/diff/1/6#newcode230
Line 230: void StatusBubbleMac::Resize() {
On 2009/10/08 18:10:32, Avi wrote:
> 1. Can we merge this sizing with the sizing done in Create(), above? Don't
like
> that it's done in two places.

Me neither. I'll add a (private) method to calculate the size/position.

> 2. The name implies that it's a request to resize the bubble rather than that
> the parent changed. How about Reposition?

I opted for the slightly-verbose "UpdateSizeAndPosition", since "Reposition"
kind of implies that it's a request to reposition the bubble ... but I'm open to
other names.

[Avi (use Gerrit), 2009-10-08 19:15:09]

LG

[pink (ping after 24hrs), 2009-10-09 14:03:26]

late drive-by

http://codereview.chromium.org/266018/diff/4001/2004
File chrome/browser/cocoa/browser_window_controller.mm (right):

http://codereview.chromium.org/266018/diff/4001/2004#newcode1077
Line 1077: if(statusBubble_.get())
space between if and paren.