Issue 266: Fix the sandbox when used with the SANDBOX_EXPORTS define.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 266: Fix the sandbox when used with the SANDBOX_EXPORTS define. (Closed)

Created:
12 years, 3 months ago by Nicolas Sylvain

Modified:
9 years, 7 months ago

Reviewers:
amit, rvargas (doing something else)

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Fix the sandbox when used with the SANDBOX_EXPORTS define. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=1820

Patch Set 1 #

Created: 12 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -7 lines)			Patch
	M	sandbox/src/filesystem_interception.h	View		1 chunk	+3 lines, -3 lines	2 comments	Download
	M	sandbox/src/policy_broker.h	View		1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

amit

12 years, 3 months ago (2008-09-07 00:19:14 UTC) #3

http://codereview.chromium.org/266/diff/1/3
File sandbox/src/filesystem_interception.h (right):

http://codereview.chromium.org/266/diff/1/3#newcode16
Line 16: SANDBOX_INTERCEPT NTSTATUS WINAPI TargetNtCreateFile(
For future needs, does it make sense to export this one as well?

http://codereview.chromium.org/266/diff/1/3#newcode25
Line 25: NtOpenFileFunction orig_OpenFile, PHANDLE file, ACCESS_MASK
desired_access,
Ditto, as above.

Expand Messages | Collapse Messages