Remove the SetExternalStringDiposeCallback API...

Remove the SetExternalStringDiposeCallback API

Changed the disposal of external string resources to call a virtual Dispose method on the resource. The default inplementation of Dispose deletes the object and will capture the delete operator matching the new operator used to allocate the object.

Committed: http://code.google.com/p/v8/source/detail?r=4816

[Vitaly Repeshko, 2010-06-07 14:24:54]

LGTM with comments.


Thanks,
Vitaly

http://codereview.chromium.org/2658008/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/2658008/diff/1/2#newcode1029
include/v8.h:1029: /**
nit: Insert a black line before the comment.

http://codereview.chromium.org/2658008/diff/1/2#newcode1031
include/v8.h:1031: * disposed.
I think we should add "The default implementation calls delete operator on
this." so that users of the API can rely on this fact and don't have to call our
Dispose.

http://codereview.chromium.org/2658008/diff/1/7
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/2658008/diff/1/7#newcode619
test/cctest/test-api.cc:619: explicit TestAsciiResourceWithDisposeControl(const
char* data, bool dispose)
nit: "explicit" not required.

[Søren Thygesen Gjesse, 2010-06-08 09:35:30]

http://codereview.chromium.org/2658008/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/2658008/diff/1/2#newcode1029
include/v8.h:1029: /**
On 2010/06/07 14:24:54, Vitaly wrote:
> nit: Insert a black line before the comment.

Done.

http://codereview.chromium.org/2658008/diff/1/2#newcode1031
include/v8.h:1031: * disposed.
On 2010/06/07 14:24:54, Vitaly wrote:
> I think we should add "The default implementation calls delete operator on
> this." so that users of the API can rely on this fact and don't have to call
our
> Dispose.

Updated comment and also made the method protected so that the API user cannot
call it.

http://codereview.chromium.org/2658008/diff/1/7
File test/cctest/test-api.cc (right):

http://codereview.chromium.org/2658008/diff/1/7#newcode619
test/cctest/test-api.cc:619: explicit TestAsciiResourceWithDisposeControl(const
char* data, bool dispose)
On 2010/06/07 14:24:54, Vitaly wrote:
> nit: "explicit" not required.

Done.