Make ChromeOS's options dialog wider for it and da.

Make ChromeOS's options dialog wider for it and da.

- Add "pp_if", "pp_ifdef" support to xtb's <if> expr;
- Use that to specify a wider width for options dialog for ChromeOS on it and da;

BUG=none
TEST=Verify options dialog tab headers are not truncaated on ChromeOS for it and da.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49256

[tony, 2010-06-07 00:51:26]

LGTM

http://codereview.chromium.org/2655003/diff/1/7
File tools/grit/grit/xtb_reader.py (right):

http://codereview.chromium.org/2655003/diff/1/7#newcode20
tools/grit/grit/xtb_reader.py:20: def __init__(self, callback, defs={},
debug=False):
Nit: Please set the default to None and if not defs: self.defines = {}. 
Otherwise, every instance shares the same instance of the default value and
adding a value to one instance will add it to the other instances that share.

http://codereview.chromium.org/2655003/diff/1/7#newcode101
tools/grit/grit/xtb_reader.py:101: def Parse(xtb_file, callback_function,
defs={}, debug=False):
Do you need to use this param?  It doesn't look like it's used?

[xiyuan, 2010-06-07 17:13:47]

CL updated to address your comments.

http://codereview.chromium.org/2655003/diff/1/7
File tools/grit/grit/xtb_reader.py (right):

http://codereview.chromium.org/2655003/diff/1/7#newcode20
tools/grit/grit/xtb_reader.py:20: def __init__(self, callback, defs={},
debug=False):
On 2010/06/07 00:51:26, tony wrote:
> Nit: Please set the default to None and if not defs: self.defines = {}. 
> Otherwise, every instance shares the same instance of the default value and
> adding a value to one instance will add it to the other instances that share.

Done. That is very good to know. :)

http://codereview.chromium.org/2655003/diff/1/7#newcode101
tools/grit/grit/xtb_reader.py:101: def Parse(xtb_file, callback_function,
defs={}, debug=False):
On 2010/06/07 00:51:26, tony wrote:
> Do you need to use this param?  It doesn't look like it's used?

Oops, forgot to update the handler creation line to pass down defs. Fixed now.

[tony, 2010-06-08 00:26:06]

LGTM

http://codereview.chromium.org/2655003/diff/5001/6005
File tools/grit/grit/tool/build.py (right):

http://codereview.chromium.org/2655003/diff/5001/6005#newcode94
tools/grit/grit/tool/build.py:94: # Set the defines so that gatherers could use
them.
Nit: This comment doesn't tell me anything the code doesn't.  Please either
revise or just remove it.

[xiyuan, 2010-06-08 22:17:36]

Done and will submit.

http://codereview.chromium.org/2655003/diff/5001/6005
File tools/grit/grit/tool/build.py (right):

http://codereview.chromium.org/2655003/diff/5001/6005#newcode94
tools/grit/grit/tool/build.py:94: # Set the defines so that gatherers could use
them.
On 2010/06/08 00:26:06, tony wrote:
> Nit: This comment doesn't tell me anything the code doesn't.  Please either
> revise or just remove it.

Done.