Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Side by Side Diff: src/liveedit.cc

Issue 2655002: Rename ThreadManager::IterateThreads to ThreadManager::IterateArchivedThreads... (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 10 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap.cc ('k') | src/v8threads.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 776 matching lines...) Expand 10 before | Expand all | Expand 10 after
787 787
788 class FrameUncookingThreadVisitor : public ThreadVisitor { 788 class FrameUncookingThreadVisitor : public ThreadVisitor {
789 public: 789 public:
790 void VisitThread(ThreadLocalTop* top) { 790 void VisitThread(ThreadLocalTop* top) {
791 StackFrame::UncookFramesForThread(top); 791 StackFrame::UncookFramesForThread(top);
792 } 792 }
793 }; 793 };
794 794
795 static void IterateAllThreads(ThreadVisitor* visitor) { 795 static void IterateAllThreads(ThreadVisitor* visitor) {
796 Top::IterateThread(visitor); 796 Top::IterateThread(visitor);
797 ThreadManager::IterateThreads(visitor); 797 ThreadManager::IterateArchivedThreads(visitor);
798 } 798 }
799 799
800 // Finds all references to original and replaces them with substitution. 800 // Finds all references to original and replaces them with substitution.
801 static void ReplaceCodeObject(Code* original, Code* substitution) { 801 static void ReplaceCodeObject(Code* original, Code* substitution) {
802 ASSERT(!Heap::InNewSpace(substitution)); 802 ASSERT(!Heap::InNewSpace(substitution));
803 803
804 AssertNoAllocation no_allocations_please; 804 AssertNoAllocation no_allocations_please;
805 805
806 // A zone scope for ReferenceCollectorVisitor. 806 // A zone scope for ReferenceCollectorVisitor.
807 ZoneScope scope(DELETE_ON_EXIT); 807 ZoneScope scope(DELETE_ON_EXIT);
(...skipping 571 matching lines...) Expand 10 before | Expand all | Expand 10 after
1379 // Fill the default values. 1379 // Fill the default values.
1380 for (int i = 0; i < len; i++) { 1380 for (int i = 0; i < len; i++) {
1381 SetElement(result, i, 1381 SetElement(result, i,
1382 Handle<Smi>(Smi::FromInt(FUNCTION_AVAILABLE_FOR_PATCH))); 1382 Handle<Smi>(Smi::FromInt(FUNCTION_AVAILABLE_FOR_PATCH)));
1383 } 1383 }
1384 1384
1385 1385
1386 // First check inactive threads. Fail if some functions are blocked there. 1386 // First check inactive threads. Fail if some functions are blocked there.
1387 InactiveThreadActivationsChecker inactive_threads_checker(shared_info_array, 1387 InactiveThreadActivationsChecker inactive_threads_checker(shared_info_array,
1388 result); 1388 result);
1389 ThreadManager::IterateThreads(&inactive_threads_checker); 1389 ThreadManager::IterateArchivedThreads(&inactive_threads_checker);
1390 if (inactive_threads_checker.HasBlockedFunctions()) { 1390 if (inactive_threads_checker.HasBlockedFunctions()) {
1391 return result; 1391 return result;
1392 } 1392 }
1393 1393
1394 // Try to drop activations from the current stack. 1394 // Try to drop activations from the current stack.
1395 const char* error_message = 1395 const char* error_message =
1396 DropActivationsInActiveThread(shared_info_array, result, do_drop); 1396 DropActivationsInActiveThread(shared_info_array, result, do_drop);
1397 if (error_message != NULL) { 1397 if (error_message != NULL) {
1398 // Add error message as an array extra element. 1398 // Add error message as an array extra element.
1399 Vector<const char> vector_message(error_message, StrLength(error_message)); 1399 Vector<const char> vector_message(error_message, StrLength(error_message));
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after
1459 1459
1460 bool LiveEditFunctionTracker::IsActive() { 1460 bool LiveEditFunctionTracker::IsActive() {
1461 return false; 1461 return false;
1462 } 1462 }
1463 1463
1464 #endif // ENABLE_DEBUGGER_SUPPORT 1464 #endif // ENABLE_DEBUGGER_SUPPORT
1465 1465
1466 1466
1467 1467
1468 } } // namespace v8::internal 1468 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap.cc ('k') | src/v8threads.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698