Issue 265032: Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 265032: Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support (Closed)

Created:
11 years, 2 months ago by rafaelw

Modified:
9 years, 7 months ago

Reviewers:
Aaron Boodman, wtc

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support. original issue: http://codereview.chromium.org/207062 The issue had to do with a symbol collison with the nss libraries (which are currently out-of-date) on the build bots. HTML Pack Extension Dialog. This removes the views implementation of the ExtensionPackDialog, and implements the dialog in html in the extensions_ui DOMUI. Additionally, support is added for packaging extensions via ---pack-extension on linux and mac BUG=20668, 20669 TBR=aa,wtc Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=28365

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+372 lines, -282 lines)			Patch
M	base/crypto/rsa_private_key.h	View		3 chunks	+6 lines, -5 lines	0 comments	Download
M	base/crypto/rsa_private_key_nss.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	base/crypto/signature_creator.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	base/crypto/signature_creator_nss.cc	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	chrome/browser/browser_init.cc	View		4 chunks	+17 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/extensions_service_unittest.cc	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.h	View		5 chunks	+17 lines, -6 lines	0 comments	Download
M	chrome/browser/extensions/extensions_ui.cc	View		6 chunks	+128 lines, -10 lines	0 comments	Download
M	chrome/browser/extensions/pack_extension_job.h	View		3 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/browser/net/chrome_url_request_context.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/resources/extensions_ui.html	View		4 chunks	+185 lines, -3 lines	0 comments	Download
D	chrome/browser/views/extensions/extension_pack_dialog.cc	View		1 chunk	+0 lines, -233 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2	3 chunks	+0 lines, -8 lines	0 comments	Download

Issue 265032: Reland: HTML Pack Extension Dialog / Linux & Mac Packaging Support (Closed)

Description

Patch Set 1 #

Patch Set 2 : args #

Patch Set 3 : blarg #