Add an API to control the disposal of external string resources...

Add an API to control the disposal of external string resources

A new callback have been added which - if set - will be called to dispose of external string resources passed from the embedder to the V8 engine.

Committed: http://code.google.com/p/v8/source/detail?r=4805

[Søren Thygesen Gjesse, 2010-06-07 06:46:18]

Should we find a better name to this API than
SetExternalStringResourceCollectedCallback? It is not really the external string
resource which has been collected. Maybe Collected -> Disposer/Finalizer or
maybe remove Resource from the name.

[Mads Ager (chromium), 2010-06-07 08:06:21]

LGTM

http://codereview.chromium.org/2645004/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/2645004/diff/1/2#newcode1125
include/v8.h:1125: * resource. When the external string is no longer live on
V8's heap and is
Remove "and is collected"?

http://codereview.chromium.org/2645004/diff/1/2#newcode1126
include/v8.h:1126: * collected the resource will be disposed either by delete
called from the
This explanation is a bit convoluted. How about:

... the resource will be disposed. If a disposal callback has been set using
SetExternalStringDiposeCallback this callback will be called to dispose the
resource. Otherwise, V8 will dispose the resource using the C++ delete operator.


?

http://codereview.chromium.org/2645004/diff/1/2#newcode1149
include/v8.h:1149: * resource. When the external string is no longer live on
V8's heap and is
Ditto.

http://codereview.chromium.org/2645004/diff/1/2#newcode1256
include/v8.h:1256: typedef void (*ExternalStringResourceCollectedCallback)
How about "ExternalStringDisposeCallback"?

http://codereview.chromium.org/2645004/diff/1/2#newcode2477
include/v8.h:2477: * Set a callback to be called when an external string
external string is no
Delete one occurrence of "external string".

http://codereview.chromium.org/2645004/diff/1/2#newcode2480
include/v8.h:2480: * the the resource using the C++ delete operator.
the the -> the

[Søren Thygesen Gjesse, 2010-06-07 08:37:58]

http://codereview.chromium.org/2645004/diff/1/2
File include/v8.h (right):

http://codereview.chromium.org/2645004/diff/1/2#newcode1125
include/v8.h:1125: * resource. When the external string is no longer live on
V8's heap and is
On 2010/06/07 08:06:22, Mads Ager wrote:
> Remove "and is collected"?

Done.

http://codereview.chromium.org/2645004/diff/1/2#newcode1126
include/v8.h:1126: * collected the resource will be disposed either by delete
called from the
On 2010/06/07 08:06:22, Mads Ager wrote:
> This explanation is a bit convoluted. How about:
> 
> ... the resource will be disposed. If a disposal callback has been set using
> SetExternalStringDiposeCallback this callback will be called to dispose the
> resource. Otherwise, V8 will dispose the resource using the C++ delete
operator.
> 
> 
> ?

Done.

http://codereview.chromium.org/2645004/diff/1/2#newcode1149
include/v8.h:1149: * resource. When the external string is no longer live on
V8's heap and is
On 2010/06/07 08:06:22, Mads Ager wrote:
> Ditto.

Done.

http://codereview.chromium.org/2645004/diff/1/2#newcode1256
include/v8.h:1256: typedef void (*ExternalStringResourceCollectedCallback)
On 2010/06/07 08:06:22, Mads Ager wrote:
> How about "ExternalStringDisposeCallback"?

Done.

http://codereview.chromium.org/2645004/diff/1/2#newcode2477
include/v8.h:2477: * Set a callback to be called when an external string
external string is no
On 2010/06/07 08:06:22, Mads Ager wrote:
> Delete one occurrence of "external string".

Done.

http://codereview.chromium.org/2645004/diff/1/2#newcode2480
include/v8.h:2480: * the the resource using the C++ delete operator.
On 2010/06/07 08:06:22, Mads Ager wrote:
> the the -> the

Done.