Simplify regexp test call when the regexp starts and ends with '.*'.

src/regexp.js

 // Copyright 2006-2009 the V8 project authors. All rights reserved.
 // Redistribution and use in source and binary forms, with or without
 // modification, are permitted provided that the following conditions are
 // met:
 //
 //     * Redistributions of source code must retain the above copyright
 //       notice, this list of conditions and the following disclaimer.
 //     * Redistributions in binary form must reproduce the above
 //       copyright notice, this list of conditions and the following
 //       disclaimer in the documentation and/or other materials provided
@@ skipping 239 matching lines @@
     cache.lastIndex = lastIndex;
     if (saveAnswer) cache.answer = CloneRegExpResult(result);
     cache.answerSaved = saveAnswer;
     cache.type = 'exec';
   }
   return result;
 
 }
 
 
+// One-element cache for the simplified test regexp.
+var regexp_key;
+var regexp_val;

[Lasse Reichstein, 2010/06/04 11:30:33]

How often do you hit this? (And how often will you hit it if you cache negative
results in the global regexp cache)?

[sandholm, 2010/06/04 11:57:23]

Caching negative results in the global regexp cache won't change the hit rate
for this cache as test is often called with a new string.

+
 // Section 15.10.6.3 doesn't actually make sense, but the intention seems to be
 // that test is defined in terms of String.prototype.exec. However, it probably
 // means the original value of String.prototype.exec, which is what everybody
 // else implements.
 function RegExpTest(string) {
   if (!IS_REGEXP(this)) {
     throw MakeTypeError('incompatible_method_receiver',
                         ['RegExp.prototype.test', this]);
   }
   if (%_ArgumentsLength() == 0) {
     var regExpInput = LAST_INPUT(lastMatchInfo);
     if (IS_UNDEFINED(regExpInput)) {
       throw MakeError('no_input_to_regexp', [this]);
     }
     string = regExpInput;
   }
   var s;
   if (IS_STRING(string)) {
     s = string;
   } else {
     s = ToString(string);
   }
 
   var lastIndex = this.lastIndex;
-
   var cache = regExpCache;
-
   if (%_ObjectEquals(cache.type, 'test') &&
       %_ObjectEquals(cache.regExp, this) &&
       %_ObjectEquals(cache.subject, string) &&
       %_ObjectEquals(cache.lastIndex, lastIndex)) {
     return cache.answer;
   }
 
+  // Remove irrelevant '.*' around a test regexp. The expression  
+  // checks whether this.source starts and ends with '.*' and that the third 
+  // char is not a '?' and that the third to last char is not a '\'. 
+  if (%_StringCharCodeAt(this.source,0) == 46 && // '.'

[Lasse Reichstein, 2010/06/04 11:30:33]

You may want to try moving this.source to a local variable. It is used a lot.
Ditto for this.source.length.

[sandholm, 2010/06/04 11:57:23]

Tried this. Causes regressions on some benchmarks

+      %_StringCharCodeAt(this.source,1) == 42 && // '*' 
+      %_StringCharCodeAt(this.source,2) != 63 && // '?'
+      %_StringCharCodeAt(this.source,this.source.length - 3) != 28 && // '\'
+      %_StringCharCodeAt(this.source,this.source.length - 2) == 46 && // '.'   
+      %_StringCharCodeAt(this.source,this.source.length - 1) == 42) { // '*'
+    if (!%_ObjectEquals(regexp_key, this)) {
+      regexp_key = this; 
+      regexp_val = new $RegExp(this.source.substring(2,
+                                                     this.source.length - 2),
+                               (this.global ? 'g' : '')
+                               + (this.ignoreCase ? 'i' : '')
+                               + (this.multiline ? 'm' : ''));
+    }
+    if (!regexp_val.test(s)) return false;

[Lasse Reichstein, 2010/06/04 11:30:33]

You can cache the negative result in the regexp cache here (using the original
regexp as key). That means that next time you call test, the global regexp cache
will match and you don't even get here.

[sandholm, 2010/06/04 11:57:23]

Often test is called with a new string so that won't really pay off in the end.

+  }
+  
   var length = s.length;
   var i = this.global ? TO_INTEGER(lastIndex) : 0;
 
   cache.type = 'test';
   cache.regExp = this;
   cache.subject = s;
   cache.lastIndex = i;
 
-  if (i < 0 || i > s.length) {
+  if (i < 0 || i > length) {
     this.lastIndex = 0;
     cache.answer = false;
     return false;
   }
 
   %_Log('regexp', 'regexp-exec,%0r,%1S,%2i', [this, s, lastIndex]);
   // matchIndices is either null or the lastMatchInfo array.
   var matchIndices = %_RegExpExec(this, s, i, lastMatchInfo);
 
   if (matchIndices == null) {
@@ skipping 206 matching lines @@
   %DefineAccessor($RegExp, "$'", SETTER, NoOpSetter, DONT_ENUM | DONT_DELETE);
 
   for (var i = 1; i < 10; ++i) {
     %DefineAccessor($RegExp, '$' + i, GETTER, RegExpMakeCaptureGetter(i), DONT_DELETE);
     %DefineAccessor($RegExp, '$' + i, SETTER, NoOpSetter, DONT_DELETE);
   }
 }
 
 
 SetupRegExp();