Issue 264069: Fail gracefully when we can't import hooks library....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 264069: Fail gracefully when we can't import hooks library.... (Closed)

Created:
11 years, 2 months ago by chase

Modified:
9 years, 7 months ago

Reviewers:
Evan Martin, M-A Ruel

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/tools/depot_tools/

Visibility:
Public.

Description

Fail gracefully when we can't import hooks library. BUG=5339 TEST=excluding depot_tools from PATH shows an instructive error, trying to run the hook with git_cl_hooks.py missing shows an instructive error Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=29156

Patch Set 1 #

Total comments: 2

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -6 lines)			Patch
	M	git-cl-upload-hook	View		1 chunk	+22 lines, -6 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

11 years, 2 months ago (2009-10-15 19:20:46 UTC) #3

http://codereview.chromium.org/264069/diff/1/2
File git-cl-upload-hook (right):

http://codereview.chromium.org/264069/diff/1/2#newcode11
Line 11: for path in os.environ.get("PATH").split(':'):
Shouldn't you use os.pathsep instead of ':' ? I don't know how cygwin would
misbehave. :)

http://codereview.chromium.org/264069/diff/1/2#newcode31
Line 31: print "ERROR: Make sure %s is up-to-date and try again." %
depot_tools_path
I think putting the depot_tools_path two times is redundant.

Expand Messages | Collapse Messages