Refactoring of crash reporting code in Chrome Frame...

Refactoring of crash reporting code in Chrome Frame

The crash reporting/vectored exception handling code that was part of the npchrome_tab project has been factored out into a separate static library.
This change includes adding new wrappers (chrome_frame_reporting.{h|cc}) around the static library in order to provide it with the correct parameters for Breakpad dump generation/reporting.
A few additional files were modified soley to cope with the changes in header files and directory structure (chrome_launcher.cc, chrome_tab.cc, chrome_frame_unittests.cc).
No actual functionality in the crash reporting for Chrome Frame has been modified, just refactored to promote better code reuse.

BUG=none
TEST=none


Committed by MAD via:
http://codereview.chromium.org/276050

[Steven Truong, 2009-10-15 17:14:50]

Hey guys, 

Having some issues with the try servers still but I realized that the upload
works, so I might as well go ahead with requesting a code review rather than
waiting on the try server fixes.

Stoyan - Please look through the re-factored crash reporting code.

Robert - Stoyan recommended to me to have you look through changes to the .gyp
files, since you understand them a bit better.

If you have any problems at all with the naming schemes, please let me know. I
just chose what I thought makes sense, but you guys are the ones who have to
live with them!

Thanks!


Steve

[robertshield, 2009-10-15 17:22:36]

http://codereview.chromium.org/264068/diff/1001/2002
File chrome_frame/crash_reporting/crash_report.cc (right):

http://codereview.chromium.org/264068/diff/1001/2002#newcode62
Line 62: google_breakpad::CustomClientInfo* client_info) {
Add a DCHECK(user_sid) and a DCHECK(client_info).

http://codereview.chromium.org/264068/diff/1001/2002#newcode66
Line 66: std::wstring pipe_name = kGoogleUpdatePipeName;
std::wstring pipe_name(kGoogleUpdatePipeName);

http://codereview.chromium.org/264068/diff/1001/2002#newcode69
Line 69: if (dump_path[0] == '\0') {
use dump_path.empty() instead.

[stoyan, 2009-10-15 17:54:11]

Generally looks Ok.
I think the tests should be moved to the new directory as well.

I'm a bit concerned that there is no way the customer of the library to
customize any policy/behaviour but we can address these later. :)

[stoyan, 2009-10-15 18:41:17]

lgtm

[robertshield, 2009-10-15 18:57:34]

lgtm