Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issue 264067: Initial port of top-level code generator to ARM. For the constant... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

Initial port of top-level code generator to ARM. For the constant true at the top level we generate: 0 stmdb sp!, {r1, r8, fp, lr} 4 add fp, sp, #8 8 ldr ip, [r10, #+4] 12 ldr r2, [r10, #+0] 16 str ip, [sp, #-4]! 20 add lr, pc, #4 24 cmp sp, r2 28 ldrcc pc, [pc, #+68] ;; code: STUB, StackCheck, minor: 0 32 ldr ip, [pc, #+68] ;; object: 0xf5bc4161 <true> 36 str ip, [sp, #-4]! 40 ldr ip, [sp, #+0] 44 str ip, [fp, #-12] 48 add sp, sp, #4 52 ldr ip, [fp, #-12] 56 str ip, [sp, #-4]! 60 ldr r0, [sp], #+4 64 mov sp, fp ;; js return 68 ldmia sp!, {fp, lr} 72 add sp, sp, #4 76 bx lr 80 ldr r0, [r10, #+4] 84 mov sp, fp ;; js return 88 ldmia sp!, {fp, lr} 92 add sp, sp, #4 96 bx lr 100 constant pool begin 104 constant 108 constant Committed: http://code.google.com/p/v8/source/detail?r=3073

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+174 lines, -21 lines) Patch
M src/SConscript View 4 chunks +2 lines, -2 lines 0 comments Download
A src/arm/fast-codegen-arm.cc View 1 1 chunk +152 lines, -0 lines 0 comments Download
M src/compiler.cc View 6 chunks +0 lines, -10 lines 0 comments Download
M src/fast-codegen.h View 3 chunks +2 lines, -3 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 1 chunk +1 line, -0 lines 0 comments Download
M tools/gyp/v8.gyp View 4 chunks +5 lines, -6 lines 0 comments Download
M tools/visual_studio/v8_base_arm.vcproj View 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-15 12:20:45 UTC) #1
Kevin Millikin (Chromium)
http://codereview.chromium.org/264067/diff/1/8 File src/arm/fast-codegen-arm.cc (right): http://codereview.chromium.org/264067/diff/1/8#newcode40 Line 40: // return address on top of them. The ...
11 years, 2 months ago (2009-10-15 12:28:54 UTC) #2
Erik Corry
11 years, 2 months ago (2009-10-15 12:32:36 UTC) #3
LGTM

Powered by Google App Engine
This is Rietveld 408576698