Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 264066: Port the initial fast code generator to x64. For the constant true in... (Closed)

Created:
11 years, 2 months ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
CC:
v8-dev
Visibility:
Public.

Description

Port the initial fast code generator to x64. For the constant true in top-level code we generate: 0 push rbp 1 movq rbp,rsp 4 push rsi 5 push rdi 6 push [r13+0x8] 10 cmpq rsp,[r13+0x0] 14 jnc 25 (0x7ff2c378ff19) 20 call 0x7ff2c377d260 ;; code: STUB, StackCheck, minor: 0 25 movq r10,0x7ff2e8608199 ;; object: 0x7ff2e8608199 <true> 35 push r10 37 movq rax,[rsp] 41 movq [rbp-0x18],rax 45 pop rax 46 push [rbp-0x18] 50 pop rax 51 movq rsp,rbp ;; js return 54 pop rbp 55 ret 0x8 58 int3 59 int3 60 int3 61 int3 62 int3 63 int3 64 movq rax,[r13+0x8] 68 movq rsp,rbp ;; js return 71 pop rbp 72 ret 0x8 75 int3 76 int3 77 int3 78 int3 79 int3 80 int3 Committed: http://code.google.com/p/v8/source/detail?r=3071

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -18 lines) Patch
M src/SConscript View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler.cc View 1 4 chunks +4 lines, -4 lines 0 comments Download
M src/fast-codegen.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M src/fast-codegen.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M src/ia32/fast-codegen-ia32.cc View 2 chunks +0 lines, -9 lines 0 comments Download
A src/x64/fast-codegen-x64.cc View 1 chunk +157 lines, -0 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/gyp/v8.gyp View 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Kevin Millikin (Chromium)
11 years, 2 months ago (2009-10-15 10:01:45 UTC) #1
William Hesse
11 years, 2 months ago (2009-10-15 10:57:08 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698