Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Unified Diff: chrome/renderer/extensions/extension_process_bindings.cc

Issue 264046: Update browser actions api to be like new design doc. (Closed)
Patch Set: rebase Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/renderer/extensions/extension_process_bindings.cc
diff --git a/chrome/renderer/extensions/extension_process_bindings.cc b/chrome/renderer/extensions/extension_process_bindings.cc
index 197bb42047f4c2777cbaec951dde0d99b57e2724..801fb9dfdae97b6003d54ae033bfac73c6e5a774 100644
--- a/chrome/renderer/extensions/extension_process_bindings.cc
+++ b/chrome/renderer/extensions/extension_process_bindings.cc
@@ -411,7 +411,9 @@ class ExtensionImpl : public ExtensionBase {
// accepts a canvas ImageData object, so it needs to do extra processing
// before sending the request to the browser.
static v8::Handle<v8::Value> SetBrowserActionIcon(const v8::Arguments& args) {
- v8::Local<v8::Object> image_data = args[1]->ToObject();
+ v8::Local<v8::Object> details = args[1]->ToObject();
+ v8::Local<v8::Object> image_data =
+ details->Get(v8::String::New("imageData"))->ToObject();
v8::Local<v8::Object> data =
image_data->Get(v8::String::New("data"))->ToObject();
int width = image_data->Get(v8::String::New("width"))->Int32Value();
« no previous file with comments | « chrome/common/extensions/extension_resource_unittest.cc ('k') | chrome/renderer/resources/extension_process_bindings.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698