chrome/browser/extensions/extension_browser_actions_api.h - Issue 264046: Update browser actions api to be like new design doc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/extension_browser_actions_api.h

Issue 264046: Update browser actions api to be like new design doc. (Closed)

Patch Set: rebase Created 11 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/extensions/extension_browser_actions_api.h

diff --git a/chrome/browser/extensions/extension_browser_actions_api.h b/chrome/browser/extensions/extension_browser_actions_api.h

index c5193d692240807a2ee97716a738cab3c9f3b09e..1becc7017ccaa93d6e1bdb3d536a3a766517d865 100755

--- a/chrome/browser/extensions/extension_browser_actions_api.h

+++ b/chrome/browser/extensions/extension_browser_actions_api.h

@@ -7,12 +7,12 @@

#include "chrome/browser/extensions/extension_function.h"

-class BrowserActionSetNameFunction : public SyncExtensionFunction {

+class BrowserActionSetIconFunction : public SyncExtensionFunction {

virtual bool RunImpl();

DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setName")

};

-class BrowserActionSetIconFunction : public SyncExtensionFunction {

+class BrowserActionSetTitleFunction : public SyncExtensionFunction {

virtual bool RunImpl();

DECLARE_EXTENSION_FUNCTION_NAME("browserAction.setIcon")

};