Update browser actions api to be like new design doc.

chrome/renderer/resources/extension_process_bindings.js

 // Copyright (c) 2009 The chrome Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This script contains privileged chrome extension related javascript APIs.
 // It is loaded by pages whose URL has the chrome-extension protocol.
 
 var chrome = chrome || {};
 (function() {
   native function GetExtensionAPIDefinition();
@@ skipping 315 matching lines @@
         tabIdProxy[name] = new chrome.Event("devtools." + tabId + "." + name);
       });
       return tabIdProxy;
     }
 
     apiFunctions["i18n.getMessage"].handleRequest =
         function(message_name, placeholders) {
       return GetL10nMessage(message_name, placeholders);
     }
 
-    apiFunctions["browserAction.setIcon"].handleRequest =
-        function(idOrImageData) {
-      if (typeof(idOrImageData) == "number") {
+    apiFunctions["browserAction.setIcon"].handleRequest = function(details) {
+      if ("iconIndex" in details) {
         sendRequest(this.name, arguments, this.definition.parameters);
-      } else if (typeof(idOrImageData) == "object") {
+      } else if ("imageData" in details) {
+        // Verify that this at least looks like an ImageData element.
+        // Unfortunately, we cannot use instanceof because the ImageData
+        // constructor is not public.
+        //
+        // We do this manually instead of using JSONSchema to avoid having these
+        // properties show up in the doc.
+        if (!("width" in details.imageData) ||
+            !("height" in details.imageData) ||
+            !("data" in details.imageData)) {
+          throw new Error(
+              "The imageData property must contain an ImageData object.");
+        }
         sendCustomRequest(SetBrowserActionIcon, "browserAction.setIcon",
-                          idOrImageData, this.definition.parameters);
+                          details, this.definition.parameters);
+      } else {
+        throw new Error(
+            "Either the iconIndex or imageData property must be specified.");
       }
     }
 
+    setupBrowserActionEvent(extensionId);
     setupPageActionEvents(extensionId);
-    setupBrowserActionEvent(extensionId);
     setupToolstripEvents(GetRenderViewId());
   });
 })();