Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5258)

Unified Diff: chrome/browser/cocoa/autocomplete_text_field_cell.h

Issue 264037: Refactor security-icon code to a more general form (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/autocomplete_text_field_cell.h
===================================================================
--- chrome/browser/cocoa/autocomplete_text_field_cell.h (revision 29797)
+++ chrome/browser/cocoa/autocomplete_text_field_cell.h (working copy)
@@ -5,6 +5,7 @@
#import <Cocoa/Cocoa.h>
#include "base/scoped_nsobject.h"
+#include "chrome/browser/cocoa/location_bar_view_mac.h"
// AutocompleteTextFieldCell customizes the look of the Omnibox text
// field. The border and focus ring are modified, as is the font
@@ -26,13 +27,10 @@
// side of the field. Exclusive WRT |keywordString_|;
scoped_nsobject<NSAttributedString> hintString_;
- // Icon that represents the state of the SSL connection
- scoped_nsobject<NSImage> hintIcon_;
-
- // Optional text that appears to the right of the hint icon which
- // appears only alongside the icon (i.e., it's possible to display a
- // hintIcon without an hintIconLabel, but not vice-versa).
- scoped_nsobject<NSAttributedString> hintIconLabel_;
+ // View showing the state of the SSL connection. Owned by the location bar.
+ // Display is exclusive WRT the |hintString_| and |keywordString_|.
+ // This may be NULL during testing.
+ LocationBarViewMac::SecurityImageView* security_image_view_;
}
// Chooses |partialString| if |width| won't fit |fullString|. Strings
@@ -54,10 +52,12 @@
availableWidth:(CGFloat)width;
- (void)clearKeywordAndHint;
-// Sets the hint icon and optional icon label. If |icon| is nil, the current
-// icon is cleared. If |label| is provided, |color| must be provided as well.
-- (void)setHintIcon:(NSImage*)icon label:(NSString*)label color:(NSColor*)color;
+- (void)setSecurityImageView:(LocationBarViewMac::SecurityImageView*)view;
+// Called when the security icon is visible and clicked. Passed through to the
+// security_image_view_ to handle the click (i.e., show the page info dialog).
+- (void)onSecurityIconMousePressed;
+
// Return the portion of the cell to show the text cursor over.
- (NSRect)textCursorFrameForFrame:(NSRect)cellFrame;
@@ -65,8 +65,9 @@
// corresponds to the frame with our added decorations sliced off.
- (NSRect)textFrameForFrame:(NSRect)cellFrame;
-// Return the portion of the cell to use for displaing the |hintIcon_|.
-- (NSRect)hintImageFrameForFrame:(NSRect)cellFrame;
+// Return the portion of the cell to use for displaying the security (SSL lock)
+// icon, leaving space for its label if any.
+- (NSRect)securityImageFrameForFrame:(NSRect)cellFrame;
@end
@@ -75,7 +76,6 @@
@property(readonly) NSAttributedString* keywordString;
@property(readonly) NSAttributedString* hintString;
-@property(readonly) NSImage* hintIcon;
@property(readonly) NSAttributedString* hintIconLabel;
@end
« no previous file with comments | « chrome/browser/cocoa/autocomplete_text_field.mm ('k') | chrome/browser/cocoa/autocomplete_text_field_cell.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698