Adding a Chrome Frame target to all.gyp to allow a continuous builder to buil...

Adding a Chrome Frame target to all.gyp to allow a continuous builder to build only the subset of projects required by Chrome Frame.

BUG=NONE
TEST=NONE

[slightlyoff, 2009-10-08 20:26:17]

LGTM. Minor nit.

http://codereview.chromium.org/264016/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/264016/diff/1/2#newcode193
Line 193: '../chrome/installer/installer.gyp:installer_util_unittests',
it would be nice if we explicitly called out the chrome.gyp:chrome task.

[Nicolas Sylvain, 2009-10-08 20:26:50]

LGTM

http://codereview.chromium.org/264016/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/264016/diff/1/2#newcode199
Line 199: '../chrome_frame/chrome_frame.gyp:npchrome_tab',
I would think that chrome_frame_perftests or any other chrome frame tests would
depend on that. Do we really need to make it explicit?

[robertshield, 2009-10-08 20:34:58]

Thanks!

http://codereview.chromium.org/264016/diff/1/2
File build/all.gyp (right):

http://codereview.chromium.org/264016/diff/1/2#newcode193
Line 193: '../chrome/installer/installer.gyp:installer_util_unittests',
On 2009/10/08 20:26:18, slightlyoff wrote:
> it would be nice if we explicitly called out the chrome.gyp:chrome task.

Done.

http://codereview.chromium.org/264016/diff/1/2#newcode199
Line 199: '../chrome_frame/chrome_frame.gyp:npchrome_tab',
On 2009/10/08 20:26:54, Nicolas Sylvain wrote:
> I would think that chrome_frame_perftests or any other chrome frame tests
would
> depend on that. Do we really need to make it explicit?

They should, but currently don't, so for the time being we need to make it
explicit.