Issue 2640007: Prepare push to trunk. We are now working on version 2.2.16.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2640007: Prepare push to trunk. We are now working on version 2.2.16. (Closed)

Created:
10 years, 6 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Prepare push to trunk. We are now working on version 2.2.16. Committed: http://code.google.com/p/v8/source/detail?r=4808

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address review comments. #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+11 lines, -1 line)			Patch
	M	ChangeLog	View	1	1 chunk	+10 lines, -0 lines	0 comments	Download
	M	src/version.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

LGTM http://codereview.chromium.org/2640007/diff/1/2 File ChangeLog (right): http://codereview.chromium.org/2640007/diff/1/2#newcode3 ChangeLog:3: Add an API to control the disposal of ...

10 years, 6 months ago (2010-06-07 10:58:22 UTC) #2

Lasse Reichstein

10 years, 6 months ago (2010-06-07 11:01:35 UTC) #3

http://codereview.chromium.org/2640007/diff/1/2
File ChangeLog (right):

http://codereview.chromium.org/2640007/diff/1/2#newcode3
ChangeLog:3: Add an API to control the disposal of external string resources
On 2010/06/07 10:58:22, Søren Gjesse wrote:
> Please add .

Done.

http://codereview.chromium.org/2640007/diff/1/2#newcode5
ChangeLog:5: Rename ThreadManager::IterateThreads to
Not really. Removed.

Expand Messages | Collapse Messages