Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 2640005: Fix tools to run on the host system during cross-compile. (Closed)

Created:
10 years, 6 months ago by Zachary Kuznia
Modified:
9 years, 7 months ago
Reviewers:
satorux1
CC:
chromium-os-reviews_chromium.org
Base URL:
ssh://gitrw.chromium.org/libchewing.git
Visibility:
Public.

Description

Fix tools to run on the host system during cross-compile. BUG=chromium-os:3864 TEST=Set up an arm build environment. Run emerge-arm-generic -a libchewing

Patch Set 1 #

Patch Set 2 : Code Review #

Total comments: 6

Patch Set 3 : Change HOST_CC to CC_FOR_BUILD #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M configure.ac View 1 chunk +3 lines, -0 lines 0 comments Download
M src/tools/Makefile.am View 1 2 1 chunk +9 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Zachary Kuznia
10 years, 6 months ago (2010-06-07 08:01:20 UTC) #1
satorux1
http://codereview.chromium.org/2640005/diff/2001/2002 File src/tools/Makefile.am (right): http://codereview.chromium.org/2640005/diff/2001/2002#newcode8 src/tools/Makefile.am:8: CFLAGS = ${HOST_CFLAGS} Looking at libchewing/autotools/config.guess, the name HOST_CC ...
10 years, 6 months ago (2010-06-07 08:27:51 UTC) #2
Zachary Kuznia
I also added a few lines to configure.in that will be important for upstreaming. http://codereview.chromium.org/2640005/diff/2001/2002 ...
10 years, 6 months ago (2010-06-07 09:11:42 UTC) #3
satorux1
10 years, 6 months ago (2010-06-07 09:17:29 UTC) #4
LGTM

Powered by Google App Engine
This is Rietveld 408576698