Issue 2640003: Remove the old RLZ dll from the chrome code. There are no code dependencies...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2640003: Remove the old RLZ dll from the chrome code. There are no code dependencies... (Closed)

Created:
10 years, 6 months ago by Roger Tawa OOO till Jul 10th

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), bradnelson, bradn

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Remove the old RLZ dll from the chrome code. There are no code dependencies on this project; its only purpose is to copy the rlz.dll file to the correct spot in the output directory. This is the first step in getting the new open source RLZ library into chromium. A following CL will add the calls to new implementation. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=49059

Patch Set 1 #

Patch Set 2 : '' #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -40 lines)			Patch
M	build/all.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/installer/mini_installer/chrome.release	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/installer/mini_installer/chrome_frame.release	View	1 chunk	+0 lines, -1 line	0 comments	Download
D	rlz/rlz.gyp	View	1 chunk	+0 lines, -36 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cpu_(ooo_6.6-7.5)

looks ok to me but I rather have bradnelson look at it. Also, there is ...

10 years, 6 months ago (2010-06-04 17:16:50 UTC) #2

LGTM

Expand Messages | Collapse Messages