Xcode project for V8

Add an Xcode project for V8.
This project exports two static library targets to be used by Chromium: jscre, v8


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=179

[iposva, 2008-09-05 21:41:04]

This is an initial version of the V8 Xcode project for use in the Chromium
project or when developing V8 on Mac OS X from within Xcode.

[Mark Mentovai, 2008-09-05 22:03:59]

Looks good otherwise, just a couple of nitty comments.

http://codereview.chromium.org/264/diff/1/2
File tools/v8.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/264/diff/1/2#newcode638
Line 638: 897FF1B70E719C2E00D62E90 /* macros.py */,
In source group v8/tools: sort these two.

http://codereview.chromium.org/264/diff/1/2#newcode748
Line 748: shellScript = "set -ex\nJS_FILES=\"runtime.js v8natives.js array.js
string.js uri.js math.js messages.js apinatives.js debug-delay.js
mirror-delay.js date-delay.js regexp-delay.js macros.py\"\n\nexport
V8ROOT=`dirname ${SRCROOT}`\necho V8ROOT=$V8ROOT\n\nexport
SRC_DIR=${V8ROOT}/src\necho ${SRC_DIR}\n\nNATIVE_JS_FILES=\"\"\n\nfor i in
${JS_FILES} ; do\n  NATIVE_JS_FILES+=\"${SRC_DIR}/${i} \"\ndone\n\nexport
DERIVED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nif [ ! -d
${DERIVED_SOURCES_DIR} ] ; then\n  mkdir ${DERIVED_SOURCES_DIR}\nfi\n\npython
${V8ROOT}/tools/js2c.py \"${DERIVED_SOURCES_DIR}/libraries.cc\"
\"${DERIVED_SOURCES_DIR}/libraries-empty.cc\" ${NATIVE_JS_FILES}\n";
When building JS_FILES, it might be nicer to put one file on each line and have
a \-broken list.  Might want to break up that long line with the python
invocation, too.

You don't need to echo V8ROOT and SRC_DIR because set -x is in effect, right?

I'd add a little more quoting on a couple things just to make sure this still
works if someone runs it from a dir that has spaces in it.

DERIVED_SOURCES_DIR is something different that Xcode exports, I'd choose a
different name for that variable.

http://codereview.chromium.org/264/diff/1/2#newcode925
Line 925: GCC_TREAT_WARNINGS_AS_ERRORS = NO;
(for Release)

Why not?

[iposva, 2008-09-05 22:24:11]

I will look at only disabling -Werror for the dtoa-config.c build in a future
CL. All other comments addressed.

http://codereview.chromium.org/264/diff/1/2
File tools/v8.xcodeproj/project.pbxproj (right):

http://codereview.chromium.org/264/diff/1/2#newcode638
Line 638: 897FF1B70E719C2E00D62E90 /* macros.py */,
done.

http://codereview.chromium.org/264/diff/1/2#newcode748
Line 748: shellScript = "set -ex\nJS_FILES=\"runtime.js v8natives.js array.js
string.js uri.js math.js messages.js apinatives.js debug-delay.js
mirror-delay.js date-delay.js regexp-delay.js macros.py\"\n\nexport
V8ROOT=`dirname ${SRCROOT}`\necho V8ROOT=$V8ROOT\n\nexport
SRC_DIR=${V8ROOT}/src\necho ${SRC_DIR}\n\nNATIVE_JS_FILES=\"\"\n\nfor i in
${JS_FILES} ; do\n  NATIVE_JS_FILES+=\"${SRC_DIR}/${i} \"\ndone\n\nexport
DERIVED_SOURCES_DIR=\"${CONFIGURATION_TEMP_DIR}/generated\"\nif [ ! -d
${DERIVED_SOURCES_DIR} ] ; then\n  mkdir ${DERIVED_SOURCES_DIR}\nfi\n\npython
${V8ROOT}/tools/js2c.py \"${DERIVED_SOURCES_DIR}/libraries.cc\"
\"${DERIVED_SOURCES_DIR}/libraries-empty.cc\" ${NATIVE_JS_FILES}\n";
- wrapped the long lines.
- echos were left from debugging before setting -x.
- Renamed the DERIVED_SOURCES_DIR to V8_GENERATED_SOURCES_DIR.

http://codereview.chromium.org/264/diff/1/2#newcode925
Line 925: GCC_TREAT_WARNINGS_AS_ERRORS = NO;
Currently there is a warning inside dtoa.c which will cause a compilation
failure when building Release. I am trying to find out how to change just  the
dtoa.c compiler flags.