Issue 2630001: Include plugin.vch files for Flash Player (on official builds).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2630001: Include plugin.vch files for Flash Player (on official builds). (Closed)

Created:
10 years, 6 months ago by vtl

Modified:
9 years, 7 months ago

Reviewers:
cpu_(ooo_6.6-7.5), Michael Moss, viettrungluu

CC:
chromium-reviews, pam+watch_chromium.org

Visibility:
Public.

Description

Include plugin.vch files for Flash Player (on official builds). BUG=none TEST=everything still builds, new-style DRM-protected content plays Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48978

Patch Set 1 #

Created: 10 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+37 lines, -12 lines)			Patch
M	chrome/chrome_exe.gypi	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/chrome_installer.gypi	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	chrome/tools/build/linux/FILES.cfg	View	2 chunks	+11 lines, -5 lines	0 comments	Download
M	chrome/tools/build/win/FILES	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/tools/build/win/FILES.cfg	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	third_party/adobe/flash/flash_player.gyp	View	1 chunk	+12 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

(Actually did a test official Chrome build on Mac. The DRM even works.)

10 years, 6 months ago (2010-06-04 17:07:55 UTC) #3

cpu_(ooo_6.6-7.5)

10 years, 6 months ago (2010-06-04 17:57:29 UTC) #4

lgtm

But I wont be surprised if there is something missing. For example I don't
recall if there is anything we need to do for chrome frame.

On 2010/06/04 17:07:55, viettrungluu wrote:
> (Actually did a test official Chrome build on Mac. The DRM even works.)

Expand Messages | Collapse Messages